Fix GMP::toNumber #4867
Merged
Fix GMP::toNumber #4867
+200
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
this seems to also affect phpstan/phpstan#12123 in which ondrej suggested to use a operator overloading extension. |
staabm
reviewed
Feb 11, 2026
| @@ -0,0 +1,34 @@ | |||
| <?php declare(strict_types = 1); | |||
Contributor
There was a problem hiding this comment.
issue 13775 also talks about array_sum which is not yet covered in tests
Contributor
|
in phpstan/phpstan#13775 (comment) there is a php version difference mentioned. should this also be taken into account here? |
VincentLanglet
commented
Feb 11, 2026
Comment on lines
-43
to
-44
| var_dump(array_sum(['5.5', false, true, new \SimpleXMLElement('<a>7.7</a>'), 5, 5.5, null])); | ||
| var_dump(array_product(['5.5', false, true, new \SimpleXMLElement('<a>7.7</a>'), 5, 5.5, null])); |
Contributor
Author
There was a problem hiding this comment.
This wasn't a valid usage, see
https://3v4l.org/GNJiY#v8.2.30
The SimpleXMLElement is silently ignored
staabm
approved these changes
Feb 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#13775
(In my understanding
Closes phpstan/phpstan#12123
(Improved later with #4873)